Log metadata and read data latencies #744
Conversation
|
/gcbrun |
Codecov Report
@@ Coverage Diff @@
## branch-2.2.x #744 +/- ##
===============================================
Coverage ? 80.29%
Complexity ? 2111
===============================================
Files ? 146
Lines ? 9549
Branches ? 1111
===============================================
Hits ? 7667
Misses ? 1420
Partials ? 462
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorageImpl.java
Outdated
Show resolved
Hide resolved
gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorageReadChannel.java
Outdated
Show resolved
Hide resolved
gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorageImpl.java
Outdated
Show resolved
Hide resolved
gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorageReadChannel.java
Outdated
Show resolved
Hide resolved
|
We should create the PR on |
|
/gcbrun |
|
/gcbrun |
gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorageImpl.java
Show resolved
Hide resolved
| object = | ||
| ResilientOperation.retry( | ||
| getObject::execute, | ||
| readBackOff.get(), | ||
| RetryDeterminer.SOCKET_ERRORS, | ||
| IOException.class, | ||
| sleeper); | ||
|
|
||
| long requestDelay = metadataStopwatch.elapsed(MILLISECONDS); | ||
| logger.atFinest().log( |
There was a problem hiding this comment.
same here with exceptions
| Thread.currentThread().getId(), | ||
| metadataStopwatch.elapsed(MILLISECONDS), | ||
| resourceId, | ||
| getObject.getLastResponseHeaders().getFirstHeaderStringValue("x-guploader-uploadid")); |
There was a problem hiding this comment.
nit: extract string literal to const
|
Please create the pr against master |
|
Closing in favor of #749 |
Log metadata and read data latencies on the JSON read path. Moreover when the latency is more than a second, log the request id fetched from the response header