Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO_NOT_SUBMIT: Test breaking change #10692

Closed

Conversation

iyabchen
Copy link
Contributor

Test breaking change

Release Note Template for Downstream PRs (will be copied)


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 deletions(-))
google-beta provider: Diff ( 2 files changed, 15 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field self_link within resource google_network_security_firewall_endpoint was either removed or renamed- reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 37
Passed tests: 36
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 deletions(-))
google-beta provider: Diff ( 2 files changed, 15 deletions(-))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field self_link within resource google_network_security_firewall_endpoint was either removed or renamed - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 37
Passed tests: 36
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages
  • networksecurity

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants