Fixes LifecycleRules Conditions not being set issue.

[kautikdk]

Fixes hashicorp/terraform-provider-google#17990

Release Note Template for Downstream PRs (will be copied)

storage: fixed a bug where `google_storage_bucket.lifecycle_rule.condition` block fields  `days_since_noncurrent_time` and `days_since_custom_time`  and `num_newer_versions` were not working for 0 value. You can now send these by including a corresponding field such as `send_days_since_noncurrent_time_if_zero` in your configuration that is set to true.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 98 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 2 files changed, 98 insertions(+), 15 deletions(-))

[kautikdk]

For tests, We can not actually check value from the cloud infra because of the empty value limitation in go language. I have added all the virtual fields to cover no permadiff happing in any case and field modification is not causing state inconsistency.

[modular-magician]

Tests analytics

Total tests: 93
Passed tests: 86
Skipped tests: 6
Affected tests: 1

Click here to see the affected service packages

• storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccStorageBucket_lifecycleRulesVirtualFields

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageBucket_lifecycleRulesVirtualFields[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[NickElliot]

LGTM -- I'm not certain we should mark this as "fixing" the issue, as we still want to update the behavior for the age condition down the line during the major release. May be appropriate to open a new ticket for that seperately, or keep the current one open.

[kautikdk]

Well, We can do it either ways. I think with this PR merged and with the no_age field, Users can set lifecycle rule conditions as they want without any problem. So we can mark this one as fixed and open new ticket for changing age behavior. That's my opinion on this but I am also okay with keeping this ticket open.

[NickElliot]

sounds good to me!

[NickElliot]

Ah sorry, these need to be included in the docs at mmv1/third_party/terraform/website/docs/r/storage_bucket.html.markdown

[kautikdk]

Oops, I forgot to add these new fields in the markdown file.
Added in the new commit.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 107 insertions(+), 18 deletions(-))
google-beta provider: Diff ( 3 files changed, 107 insertions(+), 18 deletions(-))

[modular-magician]

Tests analytics

Total tests: 94
Passed tests: 88
Skipped tests: 6
Affected tests: 0

Click here to see the affected service packages

• storage

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log