Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field update tests for google_network_securtiy_tls_inspection_policy #10729

Merged

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented May 17, 2024

Adds field update tests for google_network_securtiy_tls_inspection_policy
Took the occasion to re-arrange a bit the test code.

FYI this was moved to beta as the new fields (added with this PR) still depends by google_project_service_identity, which is still beta only. Working internally to the APIs to GA asap.

networksecurity: added field update tests for `google_network_securtiy_tls_inspection_policy`

@LucaPrete
Copy link
Member Author

@maxi-cit FYI

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 201 deletions(-))
google-beta provider: Diff ( 1 file changed, 234 insertions(+), 59 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 38
Passed tests: 36
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • networksecurity

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccNetworkSecurityTlsInspectionPolicy_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNetworkSecurityTlsInspectionPolicy_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

Copy link

This PR has been waiting for review for 2 days. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

2 similar comments
Copy link

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@LucaPrete
Copy link
Member Author

@c2thorn it seems the tls bugfix will take more than expected. Should we start to send this in in the menatime? wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants