-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field update tests for google_network_securtiy_tls_inspection_policy #10729
Add field update tests for google_network_securtiy_tls_inspection_policy #10729
Conversation
@maxi-cit FYI |
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccNetworkSecurityTlsInspectionPolicy_update |
|
This PR has been waiting for review for 2 days. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label |
2 similar comments
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team This PR has been waiting for review for 1 week. Please take a look! Use the label |
@c2thorn it seems the tls bugfix will take more than expected. Should we start to send this in in the menatime? wdyt? |
…icy (GoogleCloudPlatform#10729) Co-authored-by: Luca Prete <lucaprete@google.com>
Adds field update tests for
google_network_securtiy_tls_inspection_policy
Took the occasion to re-arrange a bit the test code.
FYI this was moved to beta as the new fields (added with this PR) still depends by
google_project_service_identity
, which is still beta only. Working internally to the APIs to GA asap.