-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add executing job support for google_cloud_run_v2_job
resource
#10734
base: main
Are you sure you want to change the base?
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudRunV2Job_cloudrunv2JobRunJobExample|TestAccCloudRunV2Job_cloudrunv2JobWithRunJobTokenUpdate |
|
This PR has been waiting for review for 2 days. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two issues from the test:
- the supplied
launch_stage
is being ignored, and returned as "GA" even though the POST request had "BETA" start_execution_token
is not being returned by the API, I'm not certain if this is expected, but the field may need anignore_read: true
tag on it
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Errors
|
Tests analyticsTotal tests: Click here to see the affected service packages
Non-exercised testsTests were added that are skipped in VCR:
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudRunV2JobIamBindingGenerated|TestAccCloudRunV2JobIamMemberGenerated|TestAccCloudRunV2JobIamPolicyGenerated|TestAccCloudRunV2Job_cloudrunv2JobBasicExample|TestAccCloudRunV2Job_cloudrunv2JobDirectvpcExample|TestAccCloudRunV2Job_cloudrunv2JobEmptydirExample|TestAccCloudRunV2Job_cloudrunv2JobFullUpdate|TestAccCloudRunV2Job_cloudrunv2JobLimitsExample|TestAccCloudRunV2Job_cloudrunv2JobRunJobExample|TestAccCloudRunV2Job_cloudrunv2JobSecretExample|TestAccCloudRunV2Job_cloudrunv2JobSqlExample|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccCloudRunV2Job_cloudrunv2JobWithDirectVPCUpdate|TestAccCloudRunV2Job_cloudrunv2JobWithGcsUpdate|TestAccCloudRunV2Job_cloudrunv2JobWithNfsUpdate|TestAccCloudRunV2Job_cloudrunv2JobWithRunJobTokenUpdate|TestAccDataSourceGoogleCloudRunV2Job_basic|TestAccDataSourceGoogleCloudRunV2Job_bindIAMPermission |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudRunV2Job_cloudrunv2JobRunJobExample|TestAccCloudRunV2Job_cloudrunv2JobWithRunJobTokenUpdate |
|
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to have camelcase for fieldnames in the yaml :)
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudRunV2Job_cloudrunv2JobRunJobExample|TestAccCloudRunV2Job_cloudrunv2JobWithRunJobTokenUpdate |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: Click here to see the affected service packages
Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudRunV2JobIamBindingGenerated|TestAccCloudRunV2JobIamMemberGenerated|TestAccCloudRunV2JobIamPolicyGenerated|TestAccCloudRunV2Job_cloudrunv2JobBasicExample|TestAccCloudRunV2Job_cloudrunv2JobEmptydirExample|TestAccCloudRunV2Job_cloudrunv2JobLimitsExample|TestAccCloudRunV2Job_cloudrunv2JobRunJobExample|TestAccCloudRunV2Job_cloudrunv2JobSecretExample|TestAccCloudRunV2Job_cloudrunv2JobSqlExample|TestAccCloudRunV2Job_cloudrunv2JobVpcaccessExample|TestAccCloudRunV2Job_cloudrunv2JobWithRunExecutionTokenUpdate|TestAccCloudRunV2Job_cloudrunv2JobWithStartExecutionTokenUpdate |
|
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
For hashicorp/terraform-provider-google#13390.
Adding field
start_execution_token
and fieldrun_execution_token
to resourcegoogle_cloud_run_v2_job
to allow executing the job automatically once the job is created or updated. This is currently add toterraform-provider-google-beta
provider only.Also changed the docker images used in job examples to the right one.
Release Note Template for Downstream PRs (will be copied)