Go Rewrite - Fix a some description diffs #10735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
NickElliot
approved these changes
May 17, 2024
avijain25
pushed a commit
to avijain25/magic-modules
that referenced
this pull request
May 21, 2024
ma-g-22
pushed a commit
to ma-g-22/magic-modules
that referenced
this pull request
May 21, 2024
pengq-google
pushed a commit
to pengq-google/magic-modules
that referenced
this pull request
May 21, 2024
Cheriit
pushed a commit
to Cheriit/magic-modules
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the diffs are mostly from the go YAML themselves not keeping the block indicator
|and the exact same indentation. I looked at the current conversion script and could not figure out a way to preserve indentation and the indicator with Ruby YAML, so we may need a secondary script to just copy/paste the descriptions after the first runs.In the meantime, here are some fixes.
Release Note Template for Downstream PRs (will be copied)