Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.openrewrite.maven:rewrite-maven-plugin from 5.27.0 to 5.30.0 #16449

Closed
wants to merge 2 commits into from

Conversation

AlbericByte
Copy link
Contributor

@AlbericByte AlbericByte commented May 14, 2024

Bump org.openrewrite.maven:rewrite-maven-plugin from 5.27.0 to 5.30.0

Fixes #16418

Description

Bump org.openrewrite.maven:rewrite-maven-plugin from 5.27.0 to 5.30.0
I have tested integration-tests successfully locally using -Dgroups=query-erro

Upgrade rewrite-maven-plugin

Release note

Upgrade org.openrewrite.maven:rewrite-maven-plugin from 5.27.0 to 5.30.0


Key changed/added classes in this PR
  • pom.xml

This PR has:

  • been self-reviewed.
  • using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@@ -656,7 +656,7 @@
</properties>
<argLine>
${jdk.strong.encapsulation.argLine}
-Xmx128m
-Xmx512m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason behind this change ? Please explain the rational behind 4x increase ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

@kgyrtkirk
Copy link
Member

I'm also not sure about Xmx changes - but #16477 have updated this to 5.31.0
so I think this might not be needed anymore

@kgyrtkirk kgyrtkirk closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants