docs: msq index page update #16459
Closed
docs: msq index page update #16459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoe
reviewed
Jun 1, 2024
docs/multi-stage-query/index.md
Outdated
| @@ -30,7 +30,7 @@ description: Introduces multi-stage query architecture and its task engine | |||
| ingestion method is right for you. | |||
| ::: | |||
|
|
|||
| Apache Druid supports SQL-based ingestion using the bundled [`druid-multi-stage-query` extension](#load-the-extension). | |||
| Apache Druid supports SQL-based ingestion using the bundled `druid-multi-stage-query` extension, which is enabled by default. | |||
There was a problem hiding this comment.
What does enabled by default mean here.
The extension is part of the example configs. Is that the definition of default here ?
There was a problem hiding this comment.
Do people generally use the example configs for production deployments?
Maybe this instead:
Suggested change
| Apache Druid supports SQL-based ingestion using the bundled `druid-multi-stage-query` extension, which is enabled by default. | |
| Apache Druid supports SQL-based ingestion using the bundled `druid-multi-stage-query` extension, which is loaded by default in the example configs if you use `./bin/start-druid` to launch Druid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like MSQ is enabled by default now, and we missed updating this line when the change happened.
Also the extern bit seems out of place down there. I think it was an accident for it to go there? I moved it next to the info about functions
This PR has: