Publish segment schema from MSQ engine #16463
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
findingrish
commented
May 16, 2024
•
findingrish
commented
- Introduce a new POJO class which extends DataSegment to include schema information. This will be sent by the workers to the Controller.
- Changes in SegmentGeneratorFrameProcessor to generate segment schema.
- Changes in ControllerImpl to publish segment schema along with segment metadata.
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
findingrish
changed the title
kfaraz
reviewed
May 17, 2024
| import java.util.Map; | ||
| import java.util.Objects; | ||
|
|
||
| public class DataSegmentExtendedWithSchema extends DataSegment |
There was a problem hiding this comment.
There is already a class DataSegmentWithMetadata, why not reuse that?
kfaraz
reviewed
May 17, 2024
| @@ -57,7 +57,7 @@ public RemoteTaskActionClient( | |||
| @Override | |||
| public <RetType> RetType submit(TaskAction<RetType> taskAction) throws IOException | |||
| { | |||
| log.debug("Performing action for task[%s]: %s", task.getId(), taskAction); | |||
| log.info("Performing action for task[%s]: %s", task.getId(), taskAction); | |||
There was a problem hiding this comment.
Is this really needed? This can cause a lot of noise in task logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.