Add ability to turn off Druid Catalog specific validation done on catalog defined tables in Druid #16465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
approved these changes
May 17, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...sts-ex/cases/src/test/java/org/apache/druid/testsEx/catalog/ITCatalogIngestAndQueryTest.java
Dismissed
Show dismissed
Hide dismissed
...sts-ex/cases/src/test/java/org/apache/druid/testsEx/catalog/ITCatalogIngestAndQueryTest.java
Dismissed
Show dismissed
Hide dismissed
jon-wei
approved these changes
May 21, 2024
ektravel
pushed a commit
to ektravel/druid
that referenced
this pull request
May 29, 2024
…alog defined tables in Druid (apache#16465) * * add property to enable / disable catalog validation and add tests * * add integration tests for catalog validation disabled * * add integration tests * * remove debugging logs * * fix forbidden api call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new query context parameter
"catalogValidationEnabled"to enable / disable catalog specific validation done on catalog defined tables in Druid. This property is enabled by default, meaning that validation is enabled. When disasbled, validation that would fail for incompatible type assignment, and adding new undefined columns to a sealed table are disabled. The decision was made to enable this property by default since if a user defines a table in the Druid catalog, then they are most likely wanting the validation that comes along with that.This PR has: