Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect-non-literal-fs-filename - add a check is it fs method at the first place #89

Closed
wants to merge 1 commit into from

Conversation

revelt
Copy link

@revelt revelt commented Jul 5, 2022

fixes #54

@revelt revelt changed the title detect-non-literal-fs-filename - add a check is it fs function's method at the first place detect-non-literal-fs-filename - add a check is it fs method at the first place Jul 5, 2022
@BuZZ-T
Copy link
Contributor

BuZZ-T commented Aug 21, 2022

Hi @revelt ! I'm sorry, i just recently noticed you tried to fix detect-non-literal-fs-filename with this PR.
I also noticed the rule only works in very special cases and does not cover a lot of them.

So my decision was to rewrite the rule. It's currently in a WIP state on my fork: https://github.com/BuZZ-T/eslint-plugin-security/tree/feature/extend-detect-non-literal-fs-filename

I also want to check if the import is really from "fs" / "node:fs" / "fs/promises" / etc...

I'd really appreciate comments once my PR is ready. I'll inform you, if you want

@revelt
Copy link
Author

revelt commented Aug 21, 2022

ok, closing

@revelt revelt closed this Aug 21, 2022
@BuZZ-T
Copy link
Contributor

BuZZ-T commented Sep 17, 2022

Hi @revelt . Here's my PR i created: #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for detect-non-literal-fs-filename
2 participants