Create diffs between BSA downloads #2220
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** Unit tests for {@link NonBlockedDomain}. */ | ||
| class NonBlockedDomainTest { |
Check notice
Code scanning / CodeQL
Unused classes and interfaces Note
| ImmutableMap<BlockList, String> fetchedChecksums = | ||
| ImmutableMap.of(BLOCK, block.peekChecksum(), BLOCK_PLUS, blockPlus.peekChecksum()); |
Check notice
Code scanning / CodeQL
Unread local variable Note
| ImmutableMap<BlockList, String> prevChecksums = | ||
| schedule | ||
| .latestCompleted() | ||
| .map(DownloadSchedule.CompletedJob::checksums) | ||
| .orElseGet(ImmutableMap::of); |
Check notice
Code scanning / CodeQL
Unread local variable Note
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** Unit tests for {@link Label}. */ | ||
| class LabelTest { |
Check notice
Code scanning / CodeQL
Unused classes and interfaces Note
weiminyu
force-pushed
the
bsa-4-make-diff
branch
from
715040f
to
e29f57d
Compare
weiminyu
force-pushed
the
bsa-4-make-diff
branch
5 times, most recently
from
941c8e4
to
92de21e
Compare
weiminyu
force-pushed
the
bsa-4-make-diff
branch
2 times, most recently
from
3b11d56
to
73de4c5
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 46 files reviewed, 7 unresolved discussions (waiting on @Github-advanced-security[bot])
core/src/main/java/google/registry/bsa/BsaDownloadAction.java line 98 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Unread local variable
Variable 'ImmutableMap<BlockList,String> fetchedChecksums' is never read.
Will be used when BSA checksum is available
core/src/main/java/google/registry/bsa/BsaDownloadAction.java line 103 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Unread local variable
Variable 'ImmutableMap<BlockList,String> prevChecksums' is never read.
Will be used when BSA checksum is available
core/src/main/java/google/registry/bsa/api/Order.java line 42 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
Fixed in next pr
core/src/test/java/google/registry/bsa/api/LabelTest.java line 25 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Unused classes and interfaces
Unused class: LabelTest is not referenced within this codebase. If not used as an external API it should be removed.
spurious github check
core/src/test/java/google/registry/bsa/api/NonBlockedDomainTest.java line 24 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Unused classes and interfaces
Unused class: NonBlockedDomainTest is not referenced within this codebase. If not used as an external API it should be removed.
spurious github check
core/src/test/java/google/registry/bsa/api/OrderTest.java line 24 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Unused classes and interfaces
Unused class: OrderTest is not referenced within this codebase. If not used as an external API it should be removed.
spurious github check
There was a problem hiding this comment.
Reviewable status: 0 of 46 files reviewed, 7 unresolved discussions (waiting on @Github-advanced-security[bot])
core/src/main/java/google/registry/bsa/BsaDiffCreator.java line 162 at r1 (raw file):
Previously, github-advanced-security[bot] wrote…
Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
Done.
| ImmutableList<Long> orderIds = | ||
| ORDER_SPLITTER | ||
| .splitToStream(columns.get(1)) | ||
| .map(Long::valueOf) |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
There was a problem hiding this comment.
Reviewable status: 0 of 46 files reviewed, 8 unresolved discussions (waiting on @Github-advanced-security[bot])
core/src/main/java/google/registry/bsa/BsaDiffCreator.java line 165 at r4 (raw file):
Previously, github-advanced-security[bot] wrote…
Missing catch of NumberFormatException
Potential uncaught 'java.lang.NumberFormatException'.
Fixed in the next pr
Add the BsaDomainRefresh class which tracks the refresh actions. The refresh actions checks for changes in the set of registered and reserved domains, which are called unblockables to BSA.
Compare the latest BSA download and the previous one to discover: * New and deleted orders * New and deleted labels as well as konwn labels referenced by new orders The diff is stored on GCS as two files, one for orders and one for diffs.
weiminyu
force-pushed
the
bsa-4-make-diff
branch
from
73de4c5
to
88dc0f1
Compare
Compare the latest BSA download and the previous one to discover:
New and deleted orders
New and deleted labels as well as konwn labels referenced by new orders
The diff is stored on GCS as two files, one for orders and one for diffs.
This change is