Change loadTestAction to use standard HTTP requests and add some tests #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AppEngineHttpRequests were creating tasks with no payload, switching to standard HTTP requests does appear to successfully get this action working again. I wrote a few unit tests to confirm this and ran the load tests in crash to confirm some actual host/contact/domain creates were enqueued. However, since this load test does not use the proxy, I do not think I will be able to use this code to simulate the limited QPS issues we have experienced during launches in the past. I did not write thorough tests and do not plan on using this action much to actually load test our system. But merging this change since I at least got it working again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is