Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some registry lock verification code #2434

Merged
merged 1 commit into from May 14, 2024

Conversation

gbrodman
Copy link
Collaborator

@gbrodman gbrodman commented May 9, 2024

The user, on the front end, should not be required to provide whether or not they're trying to verify a lock or an unlock. They should only need the verification code. We can inspect the lock object itself (and the domain in question) to see whether or not we're verifying a lock or an unlock.


This change is Reviewable

Copy link
Collaborator

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r1, 2 of 4 files at r2, all commit messages.
Reviewable status: 3 of 9 files reviewed, 1 unresolved discussion (waiting on @gbrodman)


core/src/main/java/google/registry/tools/DomainLockUtils.java line 102 at r2 (raw file):

   * <p>This assumes that the lock object / domain in question has a pending lock or unlock.
   */
  public RegistryLock verifyLockAction(String verificationCode, boolean isAdmin) {

nit: verifyLockAndUnlockAction or maybe verifyVerificationCode, would be more suitable

The user, on the front end, should not be required to provide whether or
not they're trying to verify a lock or an unlock. They should only need
the verification code. We can inspect the lock object itself (and the
domain in question) to see whether or not we're verifying a lock or an
unlock.
Copy link
Collaborator

@ptkach ptkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r1, 2 of 4 files at r2, 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gbrodman)

@gbrodman gbrodman added this pull request to the merge queue May 14, 2024
Merged via the queue into google:master with commit d09bb4f May 14, 2024
9 checks passed
@gbrodman gbrodman deleted the lockVerify branch May 14, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants