Update jetty's console build path #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is being served by vanilla Jetty, where you don't have the issue with the "expires" header. If you remove it you'd have to come up with a different way to serve the static content. If I recall correctly you didn't want the node server to be a permanent solution, right? For now you just need to change the task to copy from the correct location. Later we can work on fine tuning the parameters used by Jetty's default servlet. |
ptkach
force-pushed
the
consoleRemoveJettyArtifact
branch
from
d99dabb
to
57ff732
Compare
ptkach
changed the title
ptkach
commented
May 13, 2024
There was a problem hiding this comment.
Updated
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jianglai)
jianglai
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on a last comment in #2433.
This change is