Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avro support #113

Closed

Conversation

sjeandeaux
Copy link

@sjeandeaux sjeandeaux commented Oct 27, 2022

The PR contains the Avro support.

Configure a list of avro schema per column to be able to read any version of data.

To read avro data, we must have the schema which with we write the data.

fix #52

@sjeandeaux sjeandeaux changed the title Issue 52 support format avro feat: avro support Oct 27, 2022
@sjeandeaux
Copy link
Author

Hi,

How can we enable kokoro?

@sjeandeaux sjeandeaux force-pushed the issue-52-support-format-avro branch 3 times, most recently from 8d40b80 to 4b32abe Compare November 15, 2022 18:31
@sjeandeaux sjeandeaux requested a review from a team as a code owner November 15, 2022 18:31
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and thank you for the contribution. I think the only thing thats missing is a notice for the snappy library

THIRD_PARTY_NOTICES.txt Show resolved Hide resolved
@sjeandeaux sjeandeaux requested review from igorbernstein2 and removed request for enocom and telpirion November 18, 2022 17:02
@sjeandeaux
Copy link
Author

Should we do anything to update kokoro status?

@sjeandeaux
Copy link
Author

I've just rebased main.

@sjeandeaux
Copy link
Author

Hi,

Any chance to get a review?

- Add `avro_schema_paths` in the configuration
- Read binary with avro schemas

fix #52
@sjeandeaux
Copy link
Author

I've just rebased main

@sjeandeaux
Copy link
Author

This looks great and thank you for the contribution. I think the only thing thats missing is a notice for the snappy library

It has been fixed

@sjeandeaux
Copy link
Author

sjeandeaux commented Jan 24, 2023

Hi @igorbernstein2 ,

Thanks for your feedback.
Do you know if there is any chance to get a review?

cc @googleapis/api-bigtable

@sjeandeaux sjeandeaux closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add format support for avro
2 participants