feat: add google-c2p dependence to DirectPath

googleapis · Oct 19, 2021 · 77e81d7 · 77e81d7
1 parent 8bfcd10
commit 77e81d7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java b/gax-grpc/src/main/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProvider.java
@@ -401,7 +401,7 @@ && isOnComputeEngine()) {
     return managedChannel;
   }
 
-  /** The endpoint passed to the builder. It must have a pot, and must not have a URI scheme. */
+  /** The endpoint passed to the builder, which must have a port. */
   public String getEndpoint() {
     return endpoint;
   }

diff --git a/gax-grpc/src/test/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProviderTest.java b/gax-grpc/src/test/java/com/google/api/gax/grpc/InstantiatingGrpcChannelProviderTest.java
@@ -408,23 +408,22 @@ public void testWithDirectPathXds() throws IOException {
     ScheduledExecutorService executor = new ScheduledThreadPoolExecutor(1);
     executor.shutdown();
 
-    InstantiatingGrpcChannelProvider iProvider =
+    InstantiatingGrpcChannelProvider grpcChannelProvider =
         InstantiatingGrpcChannelProvider.newBuilder()
             .setAttemptDirectPath(true)
             .setEnvProvider(new TestEnvironmentProvider(/*isDirectPathXdsEnabled = */ "true"))
             .build();
 
-    TransportChannelProvider provider =
-        iProvider
+    TransportChannelProvider transportChannelProvider =
+        grpcChannelProvider
             .withHeaders(Collections.<String, String>emptyMap())
             .withExecutor((Executor) executor)
             .withEndpoint("localhost:8080")
             .withCredentials(ComputeEngineCredentials.create());
-    ;
 
-    provider.getTransportChannel().shutdownNow();
+    transportChannelProvider.getTransportChannel().shutdownNow();
 
-    assertEquals(iProvider.getActiveEndpoint(), "google-c2p:///localhost");
+    assertEquals(grpcChannelProvider.getActiveEndpoint(), "google-c2p:///localhost");
   }
 
   @Test