Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adding Java 7 check #2306

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/sync-repo-settings.yaml
Expand Up @@ -8,6 +8,7 @@ branchProtectionRules:
requiresCodeOwnerReviews: true
requiresStrictStatusChecks: false
requiredStatusCheckContexts:
- units (7)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is copied by owlbot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. I'll need manually set the required check via Settings of this repository once it's merged.

- units (8)
- units (11)
- windows
Expand Down
55 changes: 55 additions & 0 deletions .github/workflows/ci-java7.yaml
@@ -0,0 +1,55 @@
# Copyright 2022 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Github action job to test core java library features on
# downstream client libraries before they are released.
on:
push:
branches:
- main
pull_request:
name: ci-java7
jobs:
units:
name: "units (7)"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v1
# setup-java v2 or higher does not have version 1.7
with:
version: 1.7
architecture: x64
- run: |
java -version
# This value is used in "-Djvm=" later
echo "JAVA7_HOME=${JAVA_HOME}" >> $GITHUB_ENV
- uses: actions/setup-java@v3
with:
java-version: 17
distribution: temurin
- name: Set up Maven
uses: stCarolas/setup-maven@v4.5
with:
maven-version: 3.8.8
- name: Build
shell: bash
run: |
# Leveraging surefire's jvm option, running the test on Java 7.
# Surefire plugin 2.22.2 is the last version for Java 7. Newer version would fail with
# "UnsupportedClassVersionError: org/apache/maven/surefire/booter/ForkedBooter" error.
mvn --batch-mode --show-version -ntp test \
-Dclirr.skip=true -Denforcer.skip=true -Dmaven.javadoc.skip=true \
-Dgcloud.download.skip=true -T 1C \
-Dproject.surefire.version=2.22.2 \
-Djvm=${JAVA7_HOME}/bin/java
4 changes: 3 additions & 1 deletion pom.xml
Expand Up @@ -293,7 +293,7 @@
</plugin>
<plugin>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.1.0</version>
<version>${project.surefire.version}</version>
<configuration>
<argLine>-Xmx1024m</argLine>
<reportNameSuffix>sponge_log</reportNameSuffix>
Expand Down Expand Up @@ -510,6 +510,8 @@
<project.datanucleus-api-jdo.version>3.2.1</project.datanucleus-api-jdo.version>
<project.datanucleus-maven-plugin.version>4.0.3</project.datanucleus-maven-plugin.version>
<project.servlet-api.version>2.5</project.servlet-api.version>
<!-- Declaring surefire version as property lets us ot specify its version as Maven's argument -->
<project.surefire.version>3.0.0-M7</project.surefire.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a downgrade for 3.1.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

<deploy.autorelease>false</deploy.autorelease>
<gson.version>2.10.1</gson.version>
</properties>
Expand Down