Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): remove testing deps #4580

Merged
merged 10 commits into from
Aug 13, 2021
Merged

feat(all): remove testing deps #4580

merged 10 commits into from
Aug 13, 2021

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 9, 2021

This is a follow up for googleapis/testing-infra-docker#161.

Fixes: #4061

@codyoss codyoss requested review from broady and tbpg August 9, 2021 16:52
@codyoss codyoss requested a review from a team as a code owner August 9, 2021 16:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2021
@codyoss codyoss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 9, 2021
@codyoss
Copy link
Member Author

codyoss commented Aug 9, 2021

This needs the mentioned PR to be merged and rolled out before this can land.

@codyoss codyoss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 12, 2021
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2021
@codyoss
Copy link
Member Author

codyoss commented Aug 12, 2021

docker images have been pushed out. This is now safe to merge. Will follow up removing these deps from our other Go repos too.

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@codyoss codyoss added automerge Merge the pull request once unit tests and other checks pass. do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed automerge Merge the pull request once unit tests and other checks pass. labels Aug 13, 2021
@codyoss codyoss added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 15c1eb9 into googleapis:master Aug 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@codyoss codyoss deleted the rm-test-deps branch September 11, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: remove tool dependencies from library go.mods
2 participants