Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute/metadata): retry error when talking to metadata service #4648

Merged
merged 5 commits into from Aug 19, 2021
Merged

feat(compute/metadata): retry error when talking to metadata service #4648

merged 5 commits into from Aug 19, 2021

Commits on Aug 19, 2021

  1. feat(compute/metadata): retry error when talking to metadata service

    This was reported internally to be causing issues. This package is
    used by some of our auth flows so it should be good to make this
    package more resilient to transient failures. Implmentation inspired
    by what we do for some of our http based services.
    
    Because this package is currently not context aware I needed to add
    attempts so retrying does not happen forever. Five attempts was
    arbitrarily chosen.
    
    Fixes: #4642
    codyoss committed Aug 19, 2021
    Copy the full SHA
    7ca74cd View commit details
    Browse the repository at this point in the history
  2. review feedback

    codyoss committed Aug 19, 2021
    Copy the full SHA
    913c786 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    0a4b436 View commit details
    Browse the repository at this point in the history
  4. remove unused var

    codyoss committed Aug 19, 2021
    Copy the full SHA
    5344d1c View commit details
    Browse the repository at this point in the history
  5. add feedback

    codyoss committed Aug 19, 2021
    Copy the full SHA
    20d38dc View commit details
    Browse the repository at this point in the history