Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce inherited value for pap #7693

Merged
merged 3 commits into from
Oct 4, 2021
Merged

feat: introduce inherited value for pap #7693

merged 3 commits into from
Oct 4, 2021

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Oct 4, 2021 •
edited

Fixes #7682

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2021
@snippet-bot
Copy link

snippet-bot bot commented Oct 4, 2021 •
edited

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@frankyn frankyn added the status: blocked Resolving the issue is dependent on other work. label Oct 4, 2021
shaffeeullah
shaffeeullah reviewed Oct 4, 2021
View reviewed changes
Copy link

@shaffeeullah shaffeeullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment. Thanks, Frank!! Also, I'm assuming the inherited sample is the same as the unspecified one (except for the term change)

...loud-examples/src/test/java/com/google/cloud/examples/storage/snippets/ITBucketSnippets.java Outdated
// non-default state.
storage
.get(BUCKET)
.toBuilder()
.setIamConfiguration(
BucketInfo.IamConfiguration.newBuilder()
.setPublicAccessPrevention(BucketInfo.PublicAccessPrevention.ENFORCED)
.setPublicAccessPrevention(BucketInfo.PublicAccessPrevention.INHERITED)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should still be enforced?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.... too aggressive copy-pasting

shaffeeullah
shaffeeullah approved these changes Oct 4, 2021
View reviewed changes
Copy link

@shaffeeullah shaffeeullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch, Frank!

@frankyn frankyn added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed status: blocked Resolving the issue is dependent on other work. labels Oct 4, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 4, 2021
@frankyn frankyn marked this pull request as ready for review October 4, 2021 22:00
@frankyn frankyn requested a review from a team as a code owner October 4, 2021 22:00
BenWhitehead
BenWhitehead approved these changes Oct 4, 2021
View reviewed changes
.../main/java/com/google/cloud/examples/storage/buckets/SetPublicAccessPreventionInherited.java Outdated
.build()
.update();

System.out.println("Public access prevention is set to inherited for " + bucketName);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, inherited isn't really "highlighted" as a value here very much, and might be skimmed over by folks.

Perhaps something like Public access prevention is set to 'inherited' for ...

@frankyn frankyn added the automerge Merge the pull request once unit tests and other checks pass. label Oct 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8bc6019 into googleapis:main Oct 4, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 4, 2021
@frankyn frankyn deleted the inherited-pap branch October 5, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead approved these changes

@shaffeeullah shaffeeullah shaffeeullah approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public Access Prevention "inherited"
4 participants
@frankyn @BenWhitehead @shaffeeullah @yoshi-kokoro