Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove duplicate samples #9648

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: remove duplicate samples #9648

wants to merge 4 commits into from

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Jul 18, 2023

Removing duplicate samples which are present in java-docs-samples/ other split repos.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 18, 2023
@minherz
chore(cleanup): delete duplicated samples
33ab4c3 
* LoggingExample.java is a standalone app that differs from existing
samples by framework that allows to run different ops as a single app
(aka gcloud).
* AddLoggingHandler shows adding a handler to JUL that is unrelated
to logging library.
* CreateAndListSinks is duplicated in LoggingSnippets with
valid region tags.
* CreateAndListMetrics is duplicated in LoggingSnippets BUT does not have
valid region tags.
* WriteAndListLogEntries is duplicated in LoggingSnippets.
* SinkSnippets is duplicated in  LoggingSnippets
@minherz
chore(cleanup): remove tests for removed snippets
911ac16
@Sita04 Sita04 marked this pull request as ready for review July 24, 2023 19:37
@snippet-bot
Copy link

snippet-bot bot commented Jul 24, 2023 •
edited

Here is the summary of changes.

You are about to delete 22 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Sita04 Sita04 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 24, 2023
@suztomo
Copy link
Member

suztomo commented Oct 16, 2023

@Sita04 What was this pull request pending for, with regard to "do not merge" label?

@Sita04
Copy link
Contributor Author

Sita04 commented Oct 17, 2023

Checking for doc inclusions on this PR. Will get to it by EOW.

@Sita04 Sita04 requested a review from a team as a code owner January 18, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@suztomo suztomo

Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sita04 @suztomo @minherz