Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update NetHttpRequest to prevent silent retry of DELETE requests #1472

Merged
merged 1 commit into from Oct 7, 2021
Merged

fix: update NetHttpRequest to prevent silent retry of DELETE requests #1472

merged 1 commit into from Oct 7, 2021

Commits on Oct 5, 2021

  1. fix: update NetHttpRequest to prevent silent retry of DELETE requests 

    HttpURLConnection will silently retry `DELETE` requests.

This behavior is similar to other existing JDK bugs (JDK-6382788[1], JDK-6427251[2]).

google-http-java-client already contains a workaround for POST and PUT requests NetHttpRequest.java#L108-L112, but does not account for `DELETE` with an empty body. This change adds handling for DELETE to leverage the same workaround as POST and PUT.

[1] https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6382788
[2] https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6427251

Fixes #1471
    @BenWhitehead
    BenWhitehead committed Oct 5, 2021
    Copy the full SHA
    939f68c View commit details
    Browse the repository at this point in the history