Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing NPE bug by adding to if clause #3290

Merged
merged 3 commits into from May 8, 2024

Conversation

nick-redfearn
Copy link
Contributor

Bug fix for NPE

NPE is...

java.lang.NullPointerException: Cannot invoke "java.lang.CharSequence.length()" because "this.text" is null

From my stacktrace...

java.lang.NullPointerException: Cannot invoke "java.lang.CharSequence.length()" because "this.text" is null
	at java.base/java.util.regex.Matcher.getTextLength(Matcher.java:1808)
	at java.base/java.util.regex.Matcher.reset(Matcher.java:461)
	at java.base/java.util.regex.Matcher.(Matcher.java:256)
	at java.base/java.util.regex.Pattern.matcher(Pattern.java:1180)
	at com.google.cloud.bigquery.BigQueryImpl.create(BigQueryImpl.java:436)
	at com.google.cloud.bigquery.BigQueryImpl.create(BigQueryImpl.java:363)

Looks like a bad null check to me

@nick-redfearn nick-redfearn requested a review from a team as a code owner May 7, 2024 12:55
Copy link

google-cla bot commented May 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

conventional-commit-lint-gcf bot commented May 7, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels May 7, 2024
@nick-redfearn nick-redfearn changed the title Fixing NPE bug by adding to if clause fix: Fixing NPE bug by adding to if clause May 7, 2024
@PhongChuong
Copy link
Contributor

Thanks for contributing.
Can you run:
mvn com.coveo:fmt-maven-plugin:format
to fix the lint error (line too long).
Otherwise, approved. Just need to run few integration tests prior to merging.

@nick-redfearn
Copy link
Contributor Author

Thanks for contributing. Can you run: mvn com.coveo:fmt-maven-plugin:format to fix the lint error (line too long). Otherwise, approved. Just need to run few integration tests prior to merging.

Thanks, Ive just pushed this commit

@PhongChuong
Copy link
Contributor

/gcbrun

@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 8, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 8, 2024
@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2024
@nick-redfearn nick-redfearn requested a review from a team as a code owner May 8, 2024 16:47
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 8, 2024
@PhongChuong PhongChuong added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2024
@PhongChuong PhongChuong added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 8, 2024
@PhongChuong
Copy link
Contributor

/gcbrun

@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 8, 2024
@PhongChuong PhongChuong merged commit 127cff9 into googleapis:main May 8, 2024
18 checks passed
@PhongChuong
Copy link
Contributor

@nick-redfearn , this PR is merged. It will be included in the next release. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants