Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update profiles for DirectPath & traffic director #1974

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Oct 24, 2023

Adapt DirectPath integration tests to Traffic Director:

  • DirectPath ConnectionModes now enable attemptXds
  • Add a new connection mode for CloudPath over Traffic Director

Change-Id: Id25e77e4fd893299a688f03a48ef274fe793cc1c
@igorbernstein2 igorbernstein2 requested review from a team as code owners October 24, 2023 14:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Oct 24, 2023
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after one confirmation

@@ -239,6 +241,7 @@ private void configureUserAgent(EnhancedBigtableStubSettings.Builder stubSetting
// nothing special
break;
case REQUIRE_CFE:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to confirm, is this expected to change the settings for the REQUIRE_CFE case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants