Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove grpclb #2033

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: remove grpclb #2033

wants to merge 5 commits into from

Conversation

mohanli-ml
Copy link
Contributor

Remove attempt DirectPath gRPCLB by default in CBT Java because:

  1. gRPCLB is being deprecated, and CBT has removed all the gRPCLB traffic back to CloudPath;
  2. Attempt gRPCLB by default has known DNS amplifying issue, all: DNS request amplification with default settings google-cloud-go#7812.

@mohanli-ml mohanli-ml requested a review from a team as a code owner December 18, 2023 21:34
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 18, 2023
@mutianf mutianf added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jan 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2024
@gcf-merge-on-green GCF Merge on Green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 5, 2024
@mohanli-ml
Copy link
Contributor Author

Friendly ping. Can we merge this PR? Golang has merged googleapis/google-cloud-go#9186 so I want to make sure Java and Go has the same behavior. Thanks!

@mohanli-ml mohanli-ml requested review from a team as code owners April 18, 2024 20:23
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 18, 2024
igorbernstein2
igorbernstein2 requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please remove this line:
https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/pom.xml#L714

@mohanli-ml
Copy link
Contributor Author

Also, please remove this line: https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/pom.xml#L714

Done. Thanks Igor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mohanli-ml @igorbernstein2 @mutianf @yoshi-kokoro