chore: update copyright year for auto-generated protos #2191

gcf-owl-bot · 2024-03-30T02:54:57Z

Regenerate this pull request now.

PiperOrigin-RevId: 631538781

Source-Link: googleapis/googleapis@3597f7d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/8021fdf8d66f6005519c044d5834124b677dc919
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODAyMWZkZjhkNjZmNjAwNTUxOWMwNDRkNTgzNDEyNGI2NzdkYzkxOSJ9

BEGIN_NESTED_COMMIT
fix(deps): Update the Java code generator (gapic-generator-java) to 2.39.0
PiperOrigin-RevId: 626430774

Source-Link: googleapis/googleapis@835b84e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/43f369d90f19d09ac18720151ab106042beb811b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNmMzY5ZDkwZjE5ZDA5YWMxODcyMDE1MWFiMTA2MDQyYmViODExYiJ9

build: Update protobuf to 25.3 in WORKSPACE

PiperOrigin-RevId: 624989428

Source-Link: googleapis/googleapis@caf600a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/cc580b8ea4c07f774093d0f8c4afedd2eae6e856
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2M1ODBiOGVhNGMwN2Y3NzQwOTNkMGY4YzRhZmVkZDJlYWU2ZTg1NiJ9

feat: publish Automated Backups protos

PiperOrigin-RevId: 620381983

Source-Link: googleapis/googleapis@a70aa2c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/e3fb57f9dd4a10b6c20359ec92a72e87631991b8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTNmYjU3ZjlkZDRhMTBiNmMyMDM1OWVjOTJhNzJlODc2MzE5OTFiOCJ9
END_NESTED_COMMIT

dpebot · 2024-03-30T02:55:07Z

/gcbrun

dpebot · 2024-03-30T02:57:50Z

/gcbrun

dpebot · 2024-04-15T20:03:12Z

/gcbrun

dpebot · 2024-04-15T20:06:02Z

/gcbrun

dpebot · 2024-04-19T21:00:15Z

/gcbrun

dpebot · 2024-04-19T21:03:55Z

/gcbrun

dpebot · 2024-04-22T16:04:08Z

/gcbrun

gcf-owl-bot · 2024-04-22T16:10:35Z

Owl bot is regenerating pull request 2191...
Build name: ODFiYzcxYzgtZWVlOC00NDBmLTg4MzUtOTAwMjAxOTJjMzU0

dpebot · 2024-04-22T16:20:09Z

/gcbrun

dpebot · 2024-04-22T16:22:53Z

/gcbrun

dpebot · 2024-04-22T21:09:56Z

/gcbrun

gcf-owl-bot · 2024-04-30T17:24:24Z

Owl bot is regenerating pull request 2191...
Build name: MTUwNGExNjYtYjBlZC00OTljLTlkOTMtZDRjMDY3MGEzNzA3

….39.0 PiperOrigin-RevId: 626430774 Source-Link: googleapis/googleapis@835b84e Source-Link: googleapis/googleapis-gen@43f369d Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDNmMzY5ZDkwZjE5ZDA5YWMxODcyMDE1MWFiMTA2MDQyYmViODExYiJ9 build: Update protobuf to 25.3 in WORKSPACE PiperOrigin-RevId: 624989428 Source-Link: googleapis/googleapis@caf600a Source-Link: googleapis/googleapis-gen@cc580b8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2M1ODBiOGVhNGMwN2Y3NzQwOTNkMGY4YzRhZmVkZDJlYWU2ZTg1NiJ9 feat: publish Automated Backups protos PiperOrigin-RevId: 620381983 Source-Link: googleapis/googleapis@a70aa2c Source-Link: googleapis/googleapis-gen@e3fb57f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTNmYjU3ZjlkZDRhMTBiNmMyMDM1OWVjOTJhNzJlODc2MzE5OTFiOCJ9

dpebot · 2024-04-30T17:34:23Z

/gcbrun

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

dpebot · 2024-04-30T17:37:00Z

/gcbrun

dpebot · 2024-04-30T18:46:24Z

/gcbrun

lqiu96 · 2024-04-30T19:20:52Z

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

+  @Override
+  public String getServiceName() {
+    return "bigtable";
+  }


I noticed that EnhancedBigtableStubSettings inherits directly from StubSettings and not BigtableStubSettings:

java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

Line 95 in 26d5437

public class EnhancedBigtableStubSettings extends StubSettings<EnhancedBigtableStubSettings> {

EnhancedBigtableStubSettings will not be able to determine the serviceName because that is generated inside BigtableStubSettings. I have duplicated this here so the EnhancedStubSettings can determine the serviceName.

lqiu96 · 2024-04-30T19:24:10Z

...table/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java

@@ -613,7 +618,7 @@ UnaryCallSettings<PingAndWarmRequest, Void> pingAndWarmSettings() {

  /** Returns a builder containing all the values of this settings class. */
  public Builder toBuilder() {
-    return new Builder(this);
+    return new Builder(this).setEndpoint(getEndpoint());


patchCredentials takes in the StubSettings.Builder and not the actual StubSettings class:

java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

Lines 234 to 240 in 26d5437

EnhancedBigtableStubSettings.Builder builder = settings.toBuilder();

// TODO: this implementation is on the cusp of unwieldy, if we end up adding more features

// consider splitting it up by feature.

// workaround JWT audience issues

patchCredentials(builder);

I'm guessing there is some old historical reason for this (perhaps so that IOException isn't re-thrown), but because of this, it doesn't have access to the resolved endpoint which is determined once the StubSettings class has been created.

Implementation here:

java-bigtable/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java

Lines 400 to 404 in 26d5437

private static void patchCredentials(EnhancedBigtableStubSettings.Builder settings)

throws IOException {

int i = settings.getEndpoint().lastIndexOf(":");

String host = settings.getEndpoint().substring(0, i);

String audience = settings.getJwtAudienceMapping().get(host);

ends up calling the getEndpoint() from the Builder which returns the clientSettingsEndpoint and not the fully resolved endpoint.

This call is will set the resolved endpoint as the clientSettingsEndpoint.

PiperOrigin-RevId: 631538781 Source-Link: googleapis/googleapis@3597f7d Source-Link: googleapis/googleapis-gen@8021fdf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODAyMWZkZjhkNjZmNjAwNTUxOWMwNDRkNTgzNDEyNGI2NzdkYzkxOSJ9

dpebot · 2024-05-08T00:00:06Z

/gcbrun

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

dpebot · 2024-05-08T00:02:48Z

/gcbrun

gcf-owl-bot bot added the owl-bot-copy label Mar 30, 2024

product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 30, 2024

gcf-owl-bot bot marked this pull request as ready for review March 30, 2024 02:57

gcf-owl-bot bot requested review from a team as code owners March 30, 2024 02:57

gcf-owl-bot bot changed the title ~~feat: publish Automated Backups protos~~ build: Update protobuf to 25.3 in WORKSPACE Apr 15, 2024

product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Apr 15, 2024

gcf-owl-bot bot changed the title ~~build: Update protobuf to 25.3 in WORKSPACE~~ fix(deps): Update the Java code generator (gapic-generator-java) to 2.39.0 Apr 19, 2024

product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Apr 19, 2024

product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Apr 19, 2024

gcf-owl-bot bot force-pushed the owl-bot-copy branch from 4341a77 to a9dbe03 Compare April 22, 2024 16:19

product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Apr 22, 2024

product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Apr 22, 2024

lqiu96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024

kolea2 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 24, 2024

blakeli0 mentioned this pull request Apr 24, 2024

Downstream check should include changes from the generator googleapis/sdk-platform-java#2685

Open

gcf-owl-bot bot force-pushed the owl-bot-copy branch from 7a0ba65 to 469a092 Compare April 30, 2024 17:34

product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Apr 30, 2024

🦉 Updates from OwlBot post-processor

91068b0

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Apr 30, 2024

chore: Fix endpoint resolution

cf37a6b

lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 30, 2024

lqiu96 reviewed Apr 30, 2024

View reviewed changes

gcf-owl-bot bot changed the title ~~fix(deps): Update the Java code generator (gapic-generator-java) to 2.39.0~~ chore: update copyright year for auto-generated protos May 7, 2024

product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels May 8, 2024

🦉 Updates from OwlBot post-processor

4e7f38c

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels May 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update copyright year for auto-generated protos #2191

chore: update copyright year for auto-generated protos #2191

gcf-owl-bot bot commented Mar 30, 2024 •

edited

dpebot commented Mar 30, 2024

dpebot commented Mar 30, 2024

dpebot commented Apr 15, 2024

dpebot commented Apr 15, 2024

dpebot commented Apr 19, 2024

dpebot commented Apr 19, 2024

dpebot commented Apr 22, 2024

gcf-owl-bot bot commented Apr 22, 2024

dpebot commented Apr 22, 2024

dpebot commented Apr 22, 2024

dpebot commented Apr 22, 2024

gcf-owl-bot bot commented Apr 30, 2024

dpebot commented Apr 30, 2024

dpebot commented Apr 30, 2024

dpebot commented Apr 30, 2024

lqiu96 Apr 30, 2024 •

edited

lqiu96 Apr 30, 2024 •

edited

dpebot commented May 8, 2024

dpebot commented May 8, 2024

	EnhancedBigtableStubSettings.Builder builder = settings.toBuilder();

	// TODO: this implementation is on the cusp of unwieldy, if we end up adding more features
	// consider splitting it up by feature.

	// workaround JWT audience issues
	patchCredentials(builder);

	private static void patchCredentials(EnhancedBigtableStubSettings.Builder settings)
	throws IOException {
	int i = settings.getEndpoint().lastIndexOf(":");
	String host = settings.getEndpoint().substring(0, i);
	String audience = settings.getJwtAudienceMapping().get(host);

chore: update copyright year for auto-generated protos #2191

Are you sure you want to change the base?

chore: update copyright year for auto-generated protos #2191

Conversation

gcf-owl-bot bot commented Mar 30, 2024 • edited

dpebot commented Mar 30, 2024

dpebot commented Mar 30, 2024

dpebot commented Apr 15, 2024

dpebot commented Apr 15, 2024

dpebot commented Apr 19, 2024

dpebot commented Apr 19, 2024

dpebot commented Apr 22, 2024

gcf-owl-bot bot commented Apr 22, 2024

dpebot commented Apr 22, 2024

dpebot commented Apr 22, 2024

dpebot commented Apr 22, 2024

gcf-owl-bot bot commented Apr 30, 2024

dpebot commented Apr 30, 2024

dpebot commented Apr 30, 2024

dpebot commented Apr 30, 2024

lqiu96 Apr 30, 2024 • edited

Choose a reason for hiding this comment

lqiu96 Apr 30, 2024 • edited

Choose a reason for hiding this comment

dpebot commented May 8, 2024

dpebot commented May 8, 2024

gcf-owl-bot bot commented Mar 30, 2024 •

edited

lqiu96 Apr 30, 2024 •

edited

lqiu96 Apr 30, 2024 •

edited