Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: client.close() should wait until the channels are terminated before shutting down the executor #916

Merged
merged 2 commits into from Jul 19, 2021
Merged

fix: client.close() should wait until the channels are terminated before shutting down the executor #916

merged 2 commits into from Jul 19, 2021

Commits on Jul 16, 2021

  1. fix: client.close() should wait until the channels are terminated bef… 

    …ore shutting down the executor

Previously the client.close() would simply shutdown the channel pool and the executor immediately after. Unfortunately this leads to RPCs that would hang forever because an outstanding RPC didnt have an executor to notify of its completion. This PR ensures that the channels are drained before shutting down the executor
    @igorbernstein2
    igorbernstein2 committed Jul 16, 2021
    Copy the full SHA
    6ae2d4d View commit details
    Browse the repository at this point in the history

  2. copyright

    @igorbernstein2
    igorbernstein2 committed Jul 16, 2021
    Copy the full SHA
    fb22adc View commit details
    Browse the repository at this point in the history