Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support overriding the emulator download URL in LocalDatastoreHelper #492

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

aristide-n
Copy link
Contributor

Fixes #376

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Aug 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2021
@aristide-n aristide-n marked this pull request as draft August 9, 2021 16:51
@@ -147,7 +153,7 @@ private LocalDatastoreHelper(Builder builder) {
gcloudCommand.add("--data-dir=" + getGcdPath());
}
DownloadableEmulatorRunner downloadRunner =
new DownloadableEmulatorRunner(binCommand, EMULATOR_URL, MD5_CHECKSUM);
new DownloadableEmulatorRunner(binCommand, EMULATOR_URL, MD5_CHECKSUM, ACCESS_TOKEN);
Copy link
Contributor Author

@aristide-n aristide-n Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a google-java-core dependency version that contains googleapis/java-core#513

lesv pushed a commit to googleapis/java-core that referenced this pull request Aug 16, 2021
…513)

* feat: support downloading an emulator from an access controlled URL

fixes googleapis/java-datastore#376
used in googleapis/java-datastore#492

* fix format
@aristide-n aristide-n marked this pull request as ready for review August 16, 2021 23:17
@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@lesv
Copy link
Contributor

lesv commented Aug 17, 2021

/gcbrun

@lesv lesv added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 17, 2021
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 26, 2021
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 76397bf into googleapis:master Aug 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 26, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 1, 2021
suztomo pushed a commit to googleapis/sdk-platform-java that referenced this pull request Mar 21, 2023
…513)

* feat: support downloading an emulator from an access controlled URL

fixes googleapis/java-datastore#376
used in googleapis/java-datastore#492

* fix format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalDatastoreHelper fails to start if used in an environment that cannot access the "gcd" GCS bucket
4 participants