Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Lookup RPC OpenTelemetry Tracing #1437

Merged
merged 18 commits into from May 15, 2024
Merged

feat: Adding Lookup RPC OpenTelemetry Tracing #1437

merged 18 commits into from May 15, 2024

Conversation

jimit-j-shah
Copy link

  • Removed OpenCensus Tracing
  • Added E2E tests with Global and Local OTel SDK

Fixes #1428
datastore_otel_lookup_test_screenshot2
datastore_otel_lookup_test_screenshot
☕️

@jimit-j-shah
feat: Adding Lookup RPC OpenTelemetry Tracing
af564e6 
- Removed OpenCensus Tracing
- Added E2E tests with Global and Local OTel SDK
@jimit-j-shah jimit-j-shah requested review from a team as code owners May 10, 2024 23:29
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: datastore Issues related to the googleapis/java-datastore API. labels May 10, 2024
@jimit-j-shah jimit-j-shah self-assigned this May 10, 2024
@jimit-j-shah jimit-j-shah removed the api: datastore Issues related to the googleapis/java-datastore API. label May 10, 2024
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label May 11, 2024
kolea2
kolea2 requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to take a closer look at the integration test, left some initial feedback.

google-cloud-datastore/pom.xml Outdated Show resolved Hide resolved
google-cloud-datastore/src/main/java/com/google/cloud/datastore/DatastoreImpl.java Show resolved Hide resolved
google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITE2ETracingTest.java Outdated Show resolved Hide resolved
google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITE2ETracingTest.java Outdated Show resolved Hide resolved
google-cloud-datastore/src/test/java/com/google/cloud/datastore/it/ITE2ETracingTest.java Outdated Show resolved Hide resolved
@jimit-j-shah jimit-j-shah added the automerge Merge the pull request once unit tests and other checks pass. label May 13, 2024
@gcf-merge-on-green GCF Merge on Green
Copy link
Contributor

Your PR doesn't have any required checks. Please add required checks to your tracing-main branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks.

@jimit-j-shah jimit-j-shah removed the automerge Merge the pull request once unit tests and other checks pass. label May 13, 2024
@jimit-j-shah jimit-j-shah mentioned this pull request May 15, 2024
Closed
@jimit-j-shah jimit-j-shah merged commit 2d027e6 into tracing-main May 15, 2024
16 checks passed
@jimit-j-shah jimit-j-shah deleted the jimit/lookup-trace-3 branch May 15, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

@cindy-peng cindy-peng Awaiting requested review from cindy-peng

Assignees

@jimit-j-shah jimit-j-shah

Labels
api: datastore Issues related to the googleapis/java-datastore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimit-j-shah @kolea2