Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable server side flow control by default with the option to turn it off #426

Merged
merged 6 commits into from Nov 10, 2020
Merged

feat: Enable server side flow control by default with the option to turn it off #426

merged 6 commits into from Nov 10, 2020

Commits on Oct 30, 2020

  1. Enable server side flow control by default with the option to turn it… 

    … off

This change enables sending flow control settings automatically to the server. If FlowControlSettings.maxOutstandingElementCount > 0 or FlowControlSettings.maxOutstandingRequestBytes > 0, flow control will be enforced at the server side (in addition to the client side).

This behavior is enabled by default and Subscriber.Builder.setUseLegacyFlowControl() method is provided for users who would like to opt-out of this feature in case they encouter issues with server side flow control.
    @fayssalmartanigcp
    fayssalmartanigcp committed Oct 30, 2020
    Copy the full SHA
    6308a0e View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. feat: Enable server side flow control by default with the option to t… 

    …urn it off

This change enables sending flow control settings automatically to the server.
If FlowControlSettings.maxOutstandingElementCount > 0 or FlowControlSettings.maxOutstandingRequestBytes > 0,
flow control will be enforced at the server side (in addition to the client side).

This behavior is enabled by default and Subscriber.Builder.setUseLegacyFlowControl() method
is provided for users who would like to opt-out of this feature in case they encounter
issues with server side flow control.
    @fayssalmartanigcp
    fayssalmartanigcp committed Nov 5, 2020
    Copy the full SHA
    cfe826d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/fayssalmartanigcp/java-pu… 

    …bsub
    @fayssalmartanigcp
    fayssalmartanigcp committed Nov 5, 2020
    Copy the full SHA
    75659df View commit details
    Browse the repository at this point in the history

  3. Update google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/S… 

    …ubscriber.java

Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com>
    @fayssalmartanigcp @yoshi-code-bot
    fayssalmartanigcp and yoshi-code-bot committed Nov 5, 2020
    Copy the full SHA
    fd3dde1 View commit details
    Browse the repository at this point in the history

  4. Update google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/S… 

    …treamingSubscriberConnection.java

Co-authored-by: yoshi-code-bot <70984784+yoshi-code-bot@users.noreply.github.com>
    @fayssalmartanigcp @yoshi-code-bot
    fayssalmartanigcp and yoshi-code-bot committed Nov 5, 2020
    Copy the full SHA
    a400b70 View commit details
    Browse the repository at this point in the history

  5. Update StreamingSubscriberConnection.java

    @fayssalmartanigcp
    fayssalmartanigcp committed Nov 5, 2020
    Copy the full SHA
    e20f65f View commit details
    Browse the repository at this point in the history