Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make the stream ack deadline congruent with maxDurationPerAckExtension #447

Merged
merged 7 commits into from Nov 23, 2020
Merged

feat: make the stream ack deadline congruent with maxDurationPerAckExtension #447

merged 7 commits into from Nov 23, 2020

Commits on Nov 20, 2020

  1. feat: allow to override the stream ack deadline

    @beltran
    beltran committed Nov 20, 2020
    Copy the full SHA
    95b4fdc View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. set streamAckDeadline to be congruent with maxDurationPerAckExtension

    @beltran
    beltran committed Nov 23, 2020
    Copy the full SHA
    a0b805f View commit details
    Browse the repository at this point in the history

  2. remove extra impot

    @beltran
    beltran committed Nov 23, 2020
    Copy the full SHA
    8d32961 View commit details
    Browse the repository at this point in the history

  3. remove unused DEFAULT_STREAM_ACK_DEADLINE

    @beltran
    beltran committed Nov 23, 2020
    Copy the full SHA
    95a3c70 View commit details
    Browse the repository at this point in the history

  4. consider the case in which maxDurationPerAckExtension is not set

    @beltran
    beltran committed Nov 23, 2020
    Copy the full SHA
    efed158 View commit details
    Browse the repository at this point in the history

  5. add test

    @beltran
    beltran committed Nov 23, 2020
    Copy the full SHA
    0a773ca View commit details
    Browse the repository at this point in the history

  6. test fix

    @beltran
    beltran committed Nov 23, 2020
    Copy the full SHA
    29760b0 View commit details
    Browse the repository at this point in the history