Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: declare google-auth-library-oauth2-http #879

Closed
wants to merge 2 commits into from
Closed

deps: declare google-auth-library-oauth2-http #879

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9df15b8
deps: declare google-auth-library-oauth2-http
suztomo Oct 18, 2021
5d48058
chore: adding the auth library to ignoredUnusedDeclaredDependency
suztomo Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion google-cloud-pubsub/pom.xml
View file
Open in desktop
Expand Up @@ -41,7 +41,10 @@
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-common-protos</artifactId>
</dependency>

<dependency>
<groupId>com.google.auth</groupId>
<artifactId>google-auth-library-oauth2-http</artifactId>
</dependency>
Comment on lines +44 to +47
Copy link
Member Author

@suztomo suztomo Oct 18, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this fail the "ci / dependencies"?

<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-pubsub-v1</artifactId>
Expand Down Expand Up @@ -147,6 +150,7 @@
<ignoredUnusedDeclaredDependencies>
<ignoredUnusedDeclaredDependency>io.opencensus:opencensus-impl</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency>
<ignoredUnusedDeclaredDependency>com.google.auth:google-auth-library-oauth2-http</ignoredUnusedDeclaredDependency>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I have to mark this artifact in ignoredUnusedDeclaredDependency even though it's actually used.

Screen Shot 2021-10-18 at 4 54 11 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we won't need to add an exception when compilation becomes really broken after the new release of the shared dependencies BOM.

</ignoredUnusedDeclaredDependencies>
</configuration>
</plugin>
Expand Down