Skip to content
This repository has been archived by the owner on Sep 19, 2023. It is now read-only.

fix: dependencies.sh to work with Java 17 #516

Merged
merged 1 commit into from Nov 10, 2021
Merged

fix: dependencies.sh to work with Java 17 #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 4 additions & 7 deletions .kokoro/dependencies.sh
View file
Open in desktop
Expand Up @@ -37,16 +37,13 @@ function determineMavenOpts() {
| sed -E 's/^.*"(.*?)".*$/\1/g' \
| sed -E 's/^(1\.[0-9]\.0).*$/\1/g'
)

case $javaVersion in
"17")
if [[ $javaVersion == 17* ]]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from https://github.com/googleapis/java-storage/blob/main/.kokoro/dependencies.sh#L41

then
# MaxPermSize is no longer supported as of jdk 17
echo -n "-Xmx1024m"
;;
*)
else
echo -n "-Xmx1024m -XX:MaxPermSize=128m"
;;
esac
fi
}

export MAVEN_OPTS=$(determineMavenOpts)
Expand Down