New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert StorageImplTest from EasyMock to Mockito #270
Comments
You can always create a new test class that uses Mockito. There's no requirement that we only have one test class per model class. |
Two test classes per model class will lead to code duplication. Perhaps the right way to go is:
|
It looks like the bulk of this work is already done in the linked PRs — @frankyn is this ok to close out? |
Hi @meredithslota this is still an issue to move away from EasyMock. |
Passing it over to @JesseLovelace who had been working on this issue from last fixit |
Google requires new tests to use Mockito even if existing tests use EasyMock.
It's really hard to use two frameworks within a single test because setUp/tearDown methods invoked before and after each test perform some framework specific actions.
It's not required to convert all tests to Mockito, but the overhead of supporting both frameworks can be higher than the effort to convert existing tests.
In case of StorageImplTest, there will be many new tests developed for new Storage features, so it worths to convert these tests.
The text was updated successfully, but these errors were encountered: