Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: convert a portion of tests from easymock to mockito #330

Merged
merged 1 commit into from May 21, 2020

Conversation

dmitry-fa
Copy link
Contributor

part of #270

  • mokito tests made stronger: mocks throw an exception if not redefined explicitly
  • added missed tests for cases when RPC causes an exception
  • Storage reader()/writer() tests converted from easymock to mockito

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 20, 2020
@dmitry-fa dmitry-fa changed the title test: convert a portion of tests from easymock to mockito test: convert a portion of tests from easymock to mockito May 20, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 20, 2020
@dmitry-fa dmitry-fa requested review from frankyn and elharo May 20, 2020 16:11
@dmitry-fa dmitry-fa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2020
@dmitry-fa dmitry-fa added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #330 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #330      +/-   ##
============================================
+ Coverage     62.63%   62.71%   +0.07%     
- Complexity      553      554       +1     
============================================
  Files            31       31              
  Lines          5023     5023              
  Branches        480      480              
============================================
+ Hits           3146     3150       +4     
+ Misses         1711     1708       -3     
+ Partials        166      165       -1     
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/storage/StorageImpl.java 80.40% <0.00%> (+0.12%) 131.00% <0.00%> (ø%)
...java/com/google/cloud/storage/BlobReadChannel.java 88.23% <0.00%> (+2.52%) 17.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c7f74...ddd7951. Read the comment docs.

@dmitry-fa dmitry-fa merged commit ae0aa99 into googleapis:master May 21, 2020
@dmitry-fa dmitry-fa deleted the mockito-pin branch June 26, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants