Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update all automatic retry behavior to be idempotency aware #1132

Merged
merged 4 commits into from Nov 2, 2021
Merged

feat: update all automatic retry behavior to be idempotency aware #1132

merged 4 commits into from Nov 2, 2021

Commits on Nov 1, 2021

  1. feat: update all automatic retry behavior to be idempotency aware 

    1. Add new configuration option `StorageOptions.Builder#setStorageRetryStrategy`
2. Add new interface `StorageRetryStrategy`
3. Update all calls to be made idempotency aware
4. Change default behavior of automatic retries to only retry those operations which are deemed to be idempotent
5. Add @deprecated method `StorageRetryStrategy.getLegacyStorageRetryStrategy` providing access to a strategy which matches the previous sometimes unsafe behavior
    @BenWhitehead
    BenWhitehead committed Nov 1, 2021
    Copy the full SHA
    18a5122 View commit details
    Browse the repository at this point in the history

  2. test: make BlobWriteChannelTest cases idempotent

    @BenWhitehead
    BenWhitehead committed Nov 1, 2021
    Copy the full SHA
    d1059e7 View commit details
    Browse the repository at this point in the history

  3. test: make StorageImplMockitoTest#testCreateBlobRetry idempotent

    @BenWhitehead
    BenWhitehead committed Nov 1, 2021
    Copy the full SHA
    2d9319a View commit details
    Browse the repository at this point in the history

  4. chore: :format

    @BenWhitehead
    BenWhitehead committed Nov 1, 2021
    Copy the full SHA
    2e645bd View commit details
    Browse the repository at this point in the history