Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update StorageOptions to not overwrite any previously set host #1142

Merged
merged 1 commit into from Nov 18, 2021
Merged

fix: update StorageOptions to not overwrite any previously set host #1142

merged 1 commit into from Nov 18, 2021

Commits on Nov 10, 2021

  1. fix: update StorageOptions to not overwrite any previously set host 

    When calling `StorageOptions#toBuilder()` after creating the builder the host was explicitly set to the default host. This change removes that behavior instead moving the setting of the default host to the instantiation of a new builder.

Add unit tests to ensure host is set to the expected values based on different ways of creating an instance of StorageOptions.

Related:
* googleapis/google-cloud-java#6579
* googleapis/google-cloud-java#7004
* googleapis/google-cloud-java#7034
    @BenWhitehead
    BenWhitehead committed Nov 10, 2021
    Copy the full SHA
    3d7a4e1 View commit details
    Browse the repository at this point in the history