chore: remove WriteFlusher instead having dedicated WritableByteChannels #2514
+1,127
−843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lusher abstraction WriteFlusher has grown unwieldy to be able to properly handle the kinds of uploads that are performed while being able to perform appropriate finegrained response validation. This is the first change in a series to tease WriteFlusher apart and create an UnbufferedWritableByteChannel for each kind of upload where all logic for that upload can be encapsulated.
Make dedicated WritableByteChannel to handle chunked resumable uploads.
Make dedicated WritableByteChannel to handle streamed resumable uploads.
product-auto-label
bot
added
size: xl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteFlusher has grown unwieldy to be able to properly handle the kinds of uploads that are performed while being able to perform appropriate fine grained response validation.
This is the first change in a series to remove WriteFlusher and create purpose dedicated UnbufferedWritableByteChannels for the different kinds of uploads we perform. By having dedicated channels more fine grained response validation and request packing can be performed.
I left multiple commits in this PR for the time being. They are generally: