Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow ClientInfo to provide multiple pieces of metadata #655

Closed

Conversation

Ark-kun
Copy link

@Ark-kun Ark-kun commented May 17, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 17, 2024
@Ark-kun Ark-kun marked this pull request as ready for review May 17, 2024 19:42
@Ark-kun Ark-kun requested review from a team as code owners May 17, 2024 19:42
@parthea
Copy link
Collaborator

parthea commented May 23, 2024

Googlers see discussion in b/341382499

@parthea
Copy link
Collaborator

parthea commented Jun 4, 2024

Closing as obsolete. Please re-open if this is still needed. Please open a feature request first to discuss the approach

@parthea parthea closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants