Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make jobs awaitable with asyncio, v1 (Proof of Concept) #1802

Closed
wants to merge 8 commits into from

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Jan 26, 2024

This PR:

  • Is a proof of concept test for the eventual AsyncQueryManager
  • Should not be merged and will be closed after testing
  • Successfully showed that async functionality works cohesively with our base code

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #18 馃

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 26, 2024
tests/unit/test_client.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 29, 2024
@kiraksi kiraksi changed the title feat: make jobs awaitable with asyncio, v1 feat: make jobs awaitable with asyncio, v1 (Proof of Concept) Jan 29, 2024
@kiraksi kiraksi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 29, 2024
@kiraksi
Copy link
Contributor Author

kiraksi commented Feb 15, 2024

The tests failing for this is for pytype, which is unimportant for the purpose of this PoC PR. Closing this as a successful demonstration of the viability of asynchrony in our library.

@kiraksi kiraksi closed this Feb 15, 2024
@kiraksi kiraksi deleted the async-jobs branch February 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: make jobs awaitable
2 participants