Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit presubmit for to simplify configuration #1915

Merged
merged 18 commits into from
May 15, 2024

Conversation

chalmerlowe
Copy link
Contributor

This creates a new cfg that could be used in place of the existing kokoro presubmit test.
The intent here is to avoid using variables to skip certain nox sessions and simply call the nox sessions that we want to execute. The benefit is that...because nox sessions create the virtual env before they execute the session steps, we end up needlessly creating virtual envs for sessions that we end up skipping when we reach the skip/not skip logic.

@chalmerlowe chalmerlowe requested review from a team as code owners May 9, 2024 20:29
@chalmerlowe chalmerlowe requested a review from mrfaizal May 9, 2024 20:29
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 9, 2024
Copy link

conventional-commit-lint-gcf bot commented May 9, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 9, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels May 10, 2024
@chalmerlowe
Copy link
Contributor Author

Using base names in the config file works fine.
unit in the config will lead to unit-3.7 and unit-3.12 (whatever versions of Python are fed into the nox.session) in the results.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 13, 2024
noxfile.py Outdated Show resolved Hide resolved
@chalmerlowe chalmerlowe added kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@chalmerlowe chalmerlowe added kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title here seems out of sync with the changes, but I may be missing some context. It appears to simply be an update to the existing config, not a new one.

@chalmerlowe chalmerlowe changed the title test: add new presubmit for test purposes fix: edit presubmit for to simplify configuration May 15, 2024
@chalmerlowe chalmerlowe merged commit b739596 into main May 15, 2024
21 of 22 checks passed
@chalmerlowe chalmerlowe deleted the test-kokoro-refactor branch May 15, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants