Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove pytz #707

Merged
merged 5 commits into from Aug 12, 2021
Merged

fix: remove pytz #707

merged 5 commits into from Aug 12, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 12, 2021 •
edited

@busunkim96 busunkim96 requested a review from a team August 12, 2021 20:21
@busunkim96 busunkim96 requested a review from a team as a code owner August 12, 2021 20:21
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Aug 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@busunkim96 busunkim96 mentioned this pull request Aug 12, 2021
Closed
@chrisrossi
Copy link
Contributor

This appears to be a whitespace-only change.

@chrisrossi
Copy link
Contributor

This appears to be a whitespace-only change.

Nevermind, was accidentally looking at diff for single commit

@chrisrossi
Copy link
Contributor

Unfortunately, NDB is still required to support Python 2.7, where datetime.timezone.utc is not present. If I understand the problem to be addressed properly, we probably just need to add the pytz dependency to setup.py instead.

@busunkim96
Copy link
Contributor Author

@chrisrossi Ah makes sense. I backed out the original changes and just added pytz to the setup.py.

chrisrossi
chrisrossi approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisrossi chrisrossi merged commit 6b48548 into master Aug 12, 2021
@chrisrossi chrisrossi deleted the remove-pytz branch August 12, 2021 23:02
oliverchang added a commit to google/clusterfuzz that referenced this pull request Aug 27, 2021
@oliverchang
Add missing pytz dependency to setup.py.
cb7c3cc 
Due to googleapis/python-ndb#707.
@oliverchang oliverchang mentioned this pull request Aug 27, 2021
Merged
oliverchang added a commit to google/clusterfuzz that referenced this pull request Aug 27, 2021
@oliverchang
Add missing pytz dependency to setup.py. (#2436)
1addf69 
Due to googleapis/python-ndb#707.
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 1, 2021
@release-please
chore: release 1.10.2 (#708)
e959f4f 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.10.2](https://www.github.com/googleapis/python-ndb/compare/v1.10.1...v1.10.2) (2021-08-31)


### Bug Fixes

* **deps:** add pytz as an explicit dependency ([#707](https://www.github.com/googleapis/python-ndb/issues/707)) ([6b48548](https://www.github.com/googleapis/python-ndb/commit/6b48548a1ea4b0c125314f907c25b47992ee6556))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@busunkim96 @chrisrossi