Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(default_retention_period): Changes to copy backup path to support null expire time #963

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(default_retention_period): Changes to copy backup path to support null expire time #963

wants to merge 2 commits into from

Commits on Jun 22, 2023

  1. feat(default_retention_period): Changes to backup.create API to suppo… 

    …rt null expire time

With the default retention period feature, null value for expiration time
is a valid value. If the expiration time is not specified (null) at the
time of create backup then the backup will be retained for the duration
of maximum retention period.

In this commit, the precondition check on expiration time in the create
backup API path is removed. The condition remains intact for copy backup
API and that would be addressed in a follow-up commit.
    @satyaprakashg
    satyaprakashg committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    613d564 View commit details
    Browse the repository at this point in the history

  2. feat(default_retention_period): Changes to copy backup path to suppor… 

    …t null expire time

With the default retention period feature, null value for expiration time
is a valid value. If the expiration time of the destination backup is not
specified (null) at the time of copy backup then the destination backup
will be created with the expiration time of the source backup.

In this commit, the precondition check on expiration time in the copy
backup path is removed.
    @satyaprakashg
    satyaprakashg committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2e53490 View commit details
    Browse the repository at this point in the history