fix(merge-on-green)!: remove restrictions for checking reviews for merge on green #5231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
requested changes
Sep 27, 2023
| @@ -422,7 +422,7 @@ describe('merge-on-green wrapper logic', () => { | |||
|
|
|||
| const [reducedPRs] = handler.maybeReducePRList(prs); | |||
|
|
|||
| assert.strictEqual(reducedPRs.length, 25); | |||
| assert.ok(reducedPRs.length === 24 || reducedPRs.length === 25); | |||
There was a problem hiding this comment.
We should be confident in this value.
There was a problem hiding this comment.
I think it's OK if we're not confident. It's produced by a random value, and the only requirement is that it has to be under 25 (the chunk size):
. I've updated the test to reflect that.
sofisl
changed the title
|
Friendly ping @chingor13 |
chingor13
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we initially created merge-on-green, we weren't sure whether repos had set up branch protection adequately, so we wrote additional logic to make sure PRs had reviews. However, we've since instituted org-wide protection, this seems like an additional piece of logic now that causes a lot of confusion, see: #5193