feat: introduce new bot-framework library #5236
Open
+12,593
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
chingor13
force-pushed
the
no-probot
branch
from
fc024c3
to
7a0ba0f
Compare
chingor13
commented
Oct 3, 2023
There was a problem hiding this comment.
This was for local testing and can be removed later.
There was a problem hiding this comment.
This is for local testing and can be removed later.
SurferJeffAtGoogle
suggested changes
Nov 16, 2023
| @@ -0,0 +1,18 @@ | |||
| # foo | |||
There was a problem hiding this comment.
Imagine I want to write a new bot.* Please describe the list of services provided by this library and why I would want to use them.
- I know we said we never want to write a new bot, but I think imagining we might will result in a README that better helps maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements gcf-utils as bot-framework without probot as a dependency.
@octokit/webhooksalready handles webhook routing and signature verification.The design principles I tried to follow were:
TaskEnqueuer- queue payload for a background taskPayloadCache- save payload in a cache to save space in background taskSecretLoader- load secrets (private key, webhook secret, etc) for a botInstallationHandler- fetch bot installations (mostly used for test mocking)Rather than making this rewrite a completely breaking change for gcf-utils, I opted to make this a new library that should more or less be a drop in replacement for gcf-utils.
Other considerations:
gcf-loggerinto its own standalone package