Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hermetic-build] java-bigtable generated proto-*/src/main/proto/**/*.protos are different from existing ones #2549

Open
diegomarquezp opened this issue Mar 8, 2024 · 1 comment
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@diegomarquezp
Copy link
Contributor

diegomarquezp commented Mar 8, 2024

Problem

There are some proto files that are differing, for example bigtable/admin/v2 :

Current (wrong) generation output

See googleapis/java-bigtable#2159 for a demo PR

Details

Check googleapis - it has an update_mask entry:
https://github.com/googleapis/googleapis/blob/9868a57470a969ffa1d21194a5c05d7a6e4e98cc/google/bigtable/admin/v2/bigtable_table_admin.proto#L775-L780

Check googleapis-gen - it also has an update_mask entry:
https://github.com/googleapis/googleapis-gen/blob/b983c8f87e6643d9a74d7b8183d66349943b436e/google/bigtable/admin/v2/google-cloud-bigtable-admin-v2-java/proto-google-cloud-bigtable-admin-v2-java/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L775-L780

Check java-bigtable - it doesn't have it
https://github.com/googleapis/java-bigtable/blob/27274b4088db707e2a4cd950d61bb14bea1ded3a/proto-google-cloud-bigtable-admin-v2/src/main/proto/google/bigtable/admin/v2/bigtable_table_admin.proto#L772-L776

In owl-bot-copy PRs, the postprocessor doesn't touch the proto
googleapis/java-bigtable@0e95c92#diff-eb0acb7170b49f28d5f2eab282bb756fa72796e8db8cc65547987870ed197d20

The googleapis BUILD.bazel looks like it's not doing anything special:

proto_library(
    name = "admin_proto",
    srcs = [
        "bigtable_instance_admin.proto",
        "bigtable_table_admin.proto",
        "common.proto",
        "instance.proto",
        "table.proto",
        "types.proto",
    ],
    deps = [
        "//google/api:annotations_proto",
        "//google/api:client_proto",
        "//google/api:field_behavior_proto",
        "//google/api:resource_proto",
        "//google/iam/v1:iam_policy_proto",
        "//google/iam/v1:policy_proto",
        "//google/longrunning:operations_proto",
        "//google/rpc:status_proto",
        "@com_google_protobuf//:duration_proto",
        "@com_google_protobuf//:empty_proto",
        "@com_google_protobuf//:field_mask_proto",
        "@com_google_protobuf//:timestamp_proto",
    ],
)

This is the bigtable/admin/v2 folder:
drawing

@JoeWang1127 is this something you came across when dealing with special treatment cases of proto files? Looks like this is something occurring after generating the proto libraries

@diegomarquezp
Copy link
Contributor Author

Hopefully the only cause: There is a pending owl-bot-copy PR: googleapis/java-bigtable#2158

I'll adjust the googleapis_commitish to something before this change in the meantime

@zhumin8 zhumin8 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants