chore: write description to a file #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JoeWang1127
commented
Mar 8, 2024
| @@ -203,7 +203,7 @@ def __get_config_files(cls, path: str) -> List[tuple[str, str]]: | |||
| if sub_dir.is_file(): | |||
| continue | |||
| repo = sub_dir.name | |||
| if repo == "golden": | |||
| if repo == "golden" or repo == "java-bigtable": | |||
There was a problem hiding this comment.
Disable integration test in java-bigtable (issue)
diegomarquezp
approved these changes
Mar 8, 2024
JoeWang1127
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Context:
After #2531, we can generate pull request description from generation config and a baseline commit.
However, the return value (string) can not be retrieved when running in docker environment. Therefore, write the description to a file. Put multi-line description to a file also helps editing the pr body (link).