Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor HttpJson Callables to include Tracing #2546

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented Mar 7, 2024

Fixes: #2503

Draft to look into the impact of refactoring the HttpJsonCallableFactory to be like the GrpcCallableFactory.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Mar 7, 2024
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@lqiu96 lqiu96 changed the title Update httpjson callables chore: Refactor HttpJson Callables to include Tracing Mar 7, 2024
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Failed Quality Gate failed for 'java_showcase_integration_tests'

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpJson Implementation is recording Operation(Success|Fail) metric before retries are attempted
1 participant