feat: introduce GraalVM testing build script changes #1215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
dzou
changed the title
suztomo
reviewed
Sep 17, 2021
Comment on lines
+76
to
+79
| retry_with_backoff 3 10 \ | ||
| curl --fail --show-error --silent --location \ | ||
| https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-21.2.0/graalvm-ce-java11-linux-amd64-21.2.0.tar.gz \ | ||
| | tar xz --directory ${graalvmDir} --strip-components=1 |
There was a problem hiding this comment.
Didn't the container get this? You also wrote:
@lesv suggested implementing a dedicated GraalVM container image for testing: googleapis/testing-infra-docker#165
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the build script changes needed to introduce GraalVM testing to client library repositories. It is a follow-up to googleapis/java-shared-config#314
As discussed in googleapis/java-shared-config#314, the intention is to produce changes that are no-op's and gradually opt-in projects into GraalVM testing.
Summary of changes:
build.sh - Add an additional switch case
graalvmwhich contains the sequence of commands to install GraalVM and run unit and integration tests compiled with GraalVM native image. The switch case statement is only activated if theJOB_TYPEenv variable is set tograalvmin the Kokoro.cfgfile. Should not affect existing code which does not setJOB_TYPE=graalvm.graalvm-native.cfg - Introduces the GraalVM
.cfgthat defines the Kokoro presubmit job.In order to opt-in a project into GraalVM testing, we just need to add the corresponding
graalvm-native.cfgin google3 for each repository to start running the new presubmit job for the specified repository.Additional notes: @lesv suggested implementing a dedicated GraalVM container image for testing: googleapis/testing-infra-docker#165
cc/ @lesv @Neenu1995 @suztomo